Fix Chrome advisory parser for 2026+ blog post format#39
Merged
jasinner merged 1 commit intoJul 6, 2026
Conversation
Chrome Release blog posts from 2026 onward concatenate multiple CVE entries on a single line using [TBD][bugid] or [N/A][bugid] instead of the older [$reward][bugid] format. The existing regex splits on every opening bracket, which breaks parsing when the intro paragraph contains colons (e.g., "Note: ..."), as the first colon is mistakenly treated as the metadata/text separator. This commit replaces the single broad regex with two targeted ones: - `r"(.)\[\$"` handles the existing [$reward] pattern - `r"(?<=\S)(\[(?:TBD|N/A|\$\d+)\]\[)"` splits concatenated CVE entries using a lookbehind to only match when preceded by content
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe preprocessing regex in parse_chrome_advisory was updated to narrow newline insertion to ChangesChrome Advisory Parser Update
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome Release blog posts from 2026 onward concatenate multiple CVE entries on a single line using [TBD][bugid] or [N/A][bugid] instead of the older [$reward][bugid] format. The existing regex splits on every opening bracket, which breaks parsing when the intro paragraph contains colons (e.g., "Note: ..."), as the first colon is mistakenly treated as the metadata/text separator.
This commit replaces the single broad regex with two targeted ones:
r"(.)\[\$"handles the existing [$reward] patternr"(?<=\S)(\[(?:TBD|N/A|\$\d+)\]\[)"splits concatenated CVE entries using a lookbehind to only match when preceded by content