Allow templates from all namespaces to be processed #1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
!Verified |
myakove
requested changes
Dec 7, 2022
Contributor
Author
|
!Verified |
myakove
approved these changes
Dec 7, 2022
Collaborator
|
!NEED-REBASE |
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
!-NEED-REBASE |
myakove
approved these changes
Dec 7, 2022
Contributor
Author
|
!Verified |
Collaborator
|
@rnetser Please review |
rnetser
approved these changes
Dec 7, 2022
Contributor
Author
|
!cherry-pick v4.12 |
cnv-qe-bot
pushed a commit
that referenced
this pull request
Dec 28, 2022
* Allow templates from all namespaces to be processed * Remove TODO and add comment
|
Cherry-picked PR Allow templates from all namespaces to be processed into v4.12 |
rnetser
pushed a commit
that referenced
this pull request
Dec 28, 2022
myakove
pushed a commit
that referenced
this pull request
Aug 11, 2025
* Allow templates from all namespaces to be processed * Remove TODO and add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description:
Change the API call of processedtemplates to the current template namespace
More details:
The previous call used "openshift" namespace only, this change allow a template from any namespace to be processed
https://github.com/kubevirt/common-templates/blob/master/templates/README.md