Skip to content

Allow templates from all namespaces to be processed #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rnetser merged 3 commits into from
Dec 7, 2022
Merged

Allow templates from all namespaces to be processed #1003

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0442cbf
Allow templates from all namespaces to be processed
RoniKishner Dec 6, 2022
5f47a95
Remove TODO and add comment
RoniKishner Dec 7, 2022
29b0aac
Merge branch 'main' into template_process_namespace
RoniKishner Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ocp_resources/template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,17 @@ def process(self, client=None, **kwargs):
except KeyError:
continue
instance_dict["parameters"] = params
# TODO: remove after fix - https://issues.redhat.com/browse/KNIP-1055 (bug 1753554)
# For template validator to be used - template namespace needs to be updated
# namespace label - If not defined, the template is expected to belong to the same namespace as the VM.
instance_namespace = instance_dict["metadata"]["namespace"]
instance_dict["objects"][0]["metadata"]["labels"][
"vm.kubevirt.io/template.namespace"
] = instance_dict["metadata"]["namespace"]
] = instance_namespace

instance_json = json.dumps(instance_dict)
body = json.loads(instance_json)
response = client.request(
method="Post",
path=f"/apis/{self.api_version}/namespaces/openshift/processedtemplates",
path=f"/apis/{self.api_version}/namespaces/{instance_namespace}/processedtemplates",
body=body,
)
return response.to_dict()["objects"]
Expand Down