Hash sensitive data in resource logs #1222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/verified |
myakove
requested changes
May 15, 2023
redhat-qe-bot
added
size/M
and removed
size/S
Changes_Requested-by-myakove
Commented-by-rnetser
verified
labels
omrirh
changed the title
Contributor
Author
|
/verified |
Contributor
Author
|
/verified |
rnetser
requested changes
May 18, 2023
myakove
previously approved these changes
May 21, 2023
Contributor
Author
|
/verified |
|
Kudos, SonarCloud Quality Gate passed!
|
myakove
approved these changes
May 21, 2023
rnetser
approved these changes
May 21, 2023
Contributor
Author
|
/verified |
Contributor
Author
|
/cherry-pick v4.13 |
redhat-qe-bot
pushed a commit
that referenced
this pull request
May 21, 2023
* Omit secret data from logs * use keys attributes hashing to hide sensitive data * use benedict to modify resource dict * adding keys_to_hash attribute in resource * adding hash_log_data attribute to resource object * using hash_log_data attribute in resource object
Contributor
|
Cherry-picked PR Hash sensitive data in resource logs into v4.13 |
myakove
pushed a commit
that referenced
this pull request
May 21, 2023
* Omit secret data from logs * use keys attributes hashing to hide sensitive data * use benedict to modify resource dict * adding keys_to_hash attribute in resource * adding hash_log_data attribute to resource object * using hash_log_data attribute in resource object Co-authored-by: Omri Bar Haim <obarhaim@redhat.com>
Contributor
Author
|
/cherry-pick v4.12 |
Contributor
|
Manual cherry-pick is needed To cherry-pick run: |
omrirh
added a commit
to omrirh/openshift-python-wrapper
that referenced
this pull request
May 21, 2023
* Omit secret data from logs * use keys attributes hashing to hide sensitive data * use benedict to modify resource dict * adding keys_to_hash attribute in resource * adding hash_log_data attribute to resource object * using hash_log_data attribute in resource object
myakove
pushed a commit
that referenced
this pull request
May 21, 2023
* Hash sensitive data in resource logs (#1222) * Omit secret data from logs * use keys attributes hashing to hide sensitive data * use benedict to modify resource dict * adding keys_to_hash attribute in resource * adding hash_log_data attribute to resource object * using hash_log_data attribute in resource object * removing kubernets and python-simple-logger from dependencies
myakove
pushed a commit
that referenced
this pull request
Aug 11, 2025
* Omit secret data from logs * use keys attributes hashing to hide sensitive data * use benedict to modify resource dict * adding keys_to_hash attribute in resource * adding hash_log_data attribute to resource object * using hash_log_data attribute in resource object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.