Skip to content

Omit secret data - cherry-pick 4.12 #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2023
Merged

Omit secret data - cherry-pick 4.12 #1228

merged 2 commits into from
May 21, 2023

Conversation

@omrirh
Copy link
Contributor

@omrirh omrirh commented May 21, 2023

No description provided.

@omrirh
Hash sensitive data in resource logs (RedHatQE#1222)
5408069 
* Omit secret data from logs

* use keys attributes hashing to hide sensitive data

* use benedict to modify resource dict

* adding keys_to_hash attribute in resource

* adding hash_log_data attribute to resource object

* using hash_log_data attribute in resource object
@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented May 21, 2023

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)

Available user actions:

  • To mark PR as verified add /verified to a PR comment, to un-verify add /verified cancel to a PR comment.
    verified label removed on each new commit push.
  • To cherry pick a merged PR add /cherry-pick <target branch to cherry-pick to> to a PR comment.
    • Support only merged PRs
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
  • target-version-

@redhat-qe-bot redhat-qe-bot requested review from myakove and rnetser May 21, 2023 11:47
@myakove myakove merged commit 2a23737 into RedHatQE:v4.12 May 21, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myakove myakove myakove approved these changes

@rnetser rnetser Awaiting requested review from rnetser

Assignees

@omrirh omrirh

Labels

Approved-by-myakove branch-v4.12 size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omrirh @redhat-qe-bot @myakove