Update Backup and ClusterRole constructors and to_dict function #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Report bugs in Issues The following are automatically added:
Available user actions:
Supported labels
|
for more information, see https://pre-commit.ci
Collaborator
|
/retest sonarqube |
…pper into update_init
oharan2
changed the title
oharan2
commented
Aug 7, 2023
rnetser
requested changes
Aug 8, 2023
myakove
previously approved these changes
Aug 10, 2023
rnetser
previously approved these changes
Aug 10, 2023
…rrides spec content.
myakove
previously approved these changes
Aug 10, 2023
Contributor
Author
|
/verified |
rnetser
approved these changes
Aug 13, 2023
Collaborator
|
/cherry-pick v4.14 |
redhat-qe-bot
pushed a commit
that referenced
this pull request
Aug 13, 2023
* Update Backup and ClusterRole constuctors and to_dict function * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update backup docs * Update docs * Update documentations * Remove if not self.yaml_file * Remove upper super.to_dict() * Remove and not self.yaml_file * Update documentaions * Use res.update with excluded resources * Update docs * Remove update() usage to add excluded_resources to spec. update() overrides spec content. * Verified --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Contributor
|
Cherry-picked PR Update Backup and ClusterRole constructors and to_dict function into v4.14 |
redhat-qe-bot
added a commit
that referenced
this pull request
Aug 13, 2023
… (#1355) * Update Backup and ClusterRole constuctors and to_dict function * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update backup docs * Update docs * Update documentations * Remove if not self.yaml_file * Remove upper super.to_dict() * Remove and not self.yaml_file * Update documentaions * Use res.update with excluded resources * Update docs * Remove update() usage to add excluded_resources to spec. update() overrides spec content. * Verified --------- Co-authored-by: oharan2 <oharan@redhat.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
myakove
pushed a commit
that referenced
this pull request
Aug 11, 2025
* Update Backup and ClusterRole constuctors and to_dict function * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update backup docs * Update docs * Update documentations * Remove if not self.yaml_file * Remove upper super.to_dict() * Remove and not self.yaml_file * Update documentaions * Use res.update with excluded resources * Update docs * Remove update() usage to add excluded_resources to spec. update() overrides spec content. * Verified --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug: