Skip to content

CherryPicked: Update Backup and ClusterRole constructors and to_dict function #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2023
Merged

CherryPicked: Update Backup and ClusterRole constructors and to_dict function #1355

merged 1 commit into from
Aug 13, 2023

Conversation

@redhat-qe-bot
Copy link
Contributor

@redhat-qe-bot redhat-qe-bot commented Aug 13, 2023

No description provided.

@oharan2 @pre-commit-ci
Update Backup and ClusterRole constructors and to_dict function (#1349)
4863d75 
* Update Backup and ClusterRole constuctors and to_dict function

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update backup docs

* Update docs

* Update documentations

* Remove if not self.yaml_file

* Remove upper super.to_dict()

* Remove and not self.yaml_file

* Update documentaions

* Use res.update with excluded resources

* Update docs

* Remove update() usage to add excluded_resources to spec. update() overrides spec content.

* Verified

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@redhat-qe-bot
Copy link
Contributor Author

redhat-qe-bot commented Aug 13, 2023

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To re-run tox comment /retest tox in the PR.
  • To re-run build-container command /retest build-container in the PR.
  • To re-run python-module-install command /retest python-module-install in the PR.
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@redhat-qe-bot redhat-qe-bot self-assigned this Aug 13, 2023
@myakove myakove changed the title CherryPicked: CherryPicked: Update Backup and ClusterRole constructors and to_dict function Aug 13, 2023
@myakove
Copy link
Collaborator

myakove commented Aug 13, 2023

/lgtm

@redhat-qe-bot
Copy link
Contributor Author

redhat-qe-bot commented Aug 13, 2023

Owner of the pull request is redhat-qe-bot
Pull request is merged automatically.

@redhat-qe-bot redhat-qe-bot merged commit 8817c8b into v4.14 Aug 13, 2023
@redhat-qe-bot redhat-qe-bot deleted the CherryPicked-update_init-ewPSi branch August 13, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myakove myakove Awaiting requested review from myakove

@rnetser rnetser Awaiting requested review from rnetser

@omrirh omrirh Awaiting requested review from omrirh

@oharan2 oharan2 Awaiting requested review from oharan2

Assignees

@redhat-qe-bot redhat-qe-bot

Labels

ApprovedBy-myakove branch-v4.14 can-be-merged CherryPicked needs-rebase size/M verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@redhat-qe-bot @myakove @oharan2