Skip to content

CherryPicked: [v4.14] add more logging to vmi.wait_until_running() #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2023
Merged

CherryPicked: [v4.14] add more logging to vmi.wait_until_running() #1359

merged 1 commit into from
Aug 14, 2023

Conversation

@redhat-qe-bot
Copy link
Contributor

@redhat-qe-bot redhat-qe-bot commented Aug 14, 2023

cherry-pick #1352 into v4.14

requested-by myakove

@vsibirsk @myakove
add more logging to vmi.wait_until_running() (#1352)
fa844d4 
* add more logging to vmi.wait_until_running()

* add vmi.name to log msg

* add vm property and vm status to logs

* add raise exception if vm not found

* Remove VM object refs

---------

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
@redhat-qe-bot
Copy link
Contributor Author

redhat-qe-bot commented Aug 14, 2023

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To re-run tox comment /retest tox in the PR.
  • To re-run build-container command /retest build-container in the PR.
  • To re-run python-module-install command /retest python-module-install in the PR.
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@redhat-qe-bot redhat-qe-bot self-assigned this Aug 14, 2023
@myakove
Copy link
Collaborator

myakove commented Aug 14, 2023

/lgtm

@redhat-qe-bot redhat-qe-bot requested a review from oharan2 August 14, 2023 09:24
@myakove myakove enabled auto-merge (squash) August 14, 2023 09:24
@myakove myakove merged commit a6db04d into v4.14 Aug 14, 2023
@myakove myakove deleted the CherryPicked-update-vmi-wait-running-Gtsrd branch August 14, 2023 09:27
@redhat-qe-bot
Copy link
Contributor Author

redhat-qe-bot commented Aug 14, 2023

Owner of the pull request is redhat-qe-bot
Pull request is merged automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myakove myakove Awaiting requested review from myakove

@rnetser rnetser Awaiting requested review from rnetser

@omrirh omrirh Awaiting requested review from omrirh

@oharan2 oharan2 Awaiting requested review from oharan2

Assignees

@redhat-qe-bot redhat-qe-bot

Labels

ApprovedBy-myakove branch-v4.14 can-be-merged CherryPicked needs-rebase size/XS verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@redhat-qe-bot @myakove @vsibirsk