Skip to content

Conversation

@vsibirsk
Copy link
Contributor

@vsibirsk vsibirsk commented Aug 9, 2023

Short description:

Add more logging to VirtualMachineInstance.wait_until_running()

More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

@redhat-qe-bot
Copy link
Contributor

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To re-run tox comment /retest tox in the PR.
  • To re-run build-container command /retest build-container in the PR.
  • To re-run python-module-install command /retest python-module-install in the PR.
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@vsibirsk
Copy link
Contributor Author

vsibirsk commented Aug 9, 2023

/verified

@vsibirsk
Copy link
Contributor Author

/verified

@myakove
Copy link
Collaborator

myakove commented Aug 14, 2023

/lgtm

@myakove
Copy link
Collaborator

myakove commented Aug 14, 2023

/verified

@myakove myakove enabled auto-merge (squash) August 14, 2023 08:33
@myakove
Copy link
Collaborator

myakove commented Aug 14, 2023

/cherry-pick v4.14

@redhat-qe-bot
Copy link
Contributor

Cherry-pick requested for PR: add more logging to vmi.wait_until_running() by user myakove
Adding label/s cherry-pick-v4.14 for automatic cheery-pick once the PR is merged

@myakove
Copy link
Collaborator

myakove commented Aug 14, 2023

/lgtm

@myakove myakove merged commit 8fd52ef into RedHatQE:main Aug 14, 2023
redhat-qe-bot pushed a commit that referenced this pull request Aug 14, 2023
* add more logging to vmi.wait_until_running()

* add vmi.name to log msg

* add vm property and vm status to logs

* add raise exception if vm not found

* Remove VM object refs

---------

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
@redhat-qe-bot
Copy link
Contributor

Cherry-picked PR add more logging to vmi.wait_until_running() into v4.14

redhat-qe-bot pushed a commit that referenced this pull request Aug 14, 2023
* add more logging to vmi.wait_until_running()

* add vmi.name to log msg

* add vm property and vm status to logs

* add raise exception if vm not found

* Remove VM object refs

---------

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
@myakove
Copy link
Collaborator

myakove commented Aug 14, 2023

/cherry-pick v4.14

redhat-qe-bot pushed a commit that referenced this pull request Aug 14, 2023
* add more logging to vmi.wait_until_running()

* add vmi.name to log msg

* add vm property and vm status to logs

* add raise exception if vm not found

* Remove VM object refs

---------

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
@redhat-qe-bot
Copy link
Contributor

Cherry-picked PR add more logging to vmi.wait_until_running() into v4.14

myakove added a commit that referenced this pull request Aug 14, 2023
* add more logging to vmi.wait_until_running()

* add vmi.name to log msg

* add vm property and vm status to logs

* add raise exception if vm not found

* Remove VM object refs

---------

Co-authored-by: vsibirsk <57763370+vsibirsk@users.noreply.github.com>
Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
@vsibirsk vsibirsk deleted the update-vmi-wait-running branch August 31, 2023 10:03
myakove added a commit that referenced this pull request Aug 11, 2025
* add more logging to vmi.wait_until_running()

* add vmi.name to log msg

* add vm property and vm status to logs

* add raise exception if vm not found

* Remove VM object refs

---------

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants