Skip to content

Update configmap class constructor and documentation #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 11, 2023
Merged

Update configmap class constructor and documentation #1422

merged 4 commits into from
Sep 11, 2023

Conversation

@oharan2
Copy link
Contributor

@oharan2 oharan2 commented Sep 6, 2023

Fix class constructor to not demand upper (super) classes args, fixed documentation

@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Sep 6, 2023

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To re-run tox comment /retest tox in the PR.
  • To re-run build-container command /retest build-container in the PR.
  • To re-run python-module-install command /retest python-module-install in the PR.
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@redhat-qe-bot redhat-qe-bot mentioned this pull request Sep 6, 2023
Closed
@oharan2 oharan2 mentioned this pull request Sep 6, 2023
Closed
rnetser
rnetser requested changes Sep 6, 2023
View reviewed changes
rnetser
rnetser requested changes Sep 6, 2023
View reviewed changes
@oharan2
Copy link
Contributor Author

oharan2 commented Sep 11, 2023

/verified

@rnetser
Copy link
Collaborator

rnetser commented Sep 11, 2023

/lgtm

@rnetser
Copy link
Collaborator

rnetser commented Sep 11, 2023

/verified

@rnetser rnetser enabled auto-merge (squash) September 11, 2023 12:00
@rnetser rnetser merged commit 6181233 into RedHatQE:main Sep 11, 2023
@oharan2
Copy link
Contributor Author

oharan2 commented Sep 11, 2023

/cherry-pick v4.14 v4.15

1 similar comment
@oharan2
Copy link
Contributor Author

oharan2 commented Sep 11, 2023

/cherry-pick v4.14 v4.15

This was referenced Sep 11, 2023
Merged
Merged
@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Sep 11, 2023

Cherry-picked PR Update configmap class constructor and documentation into v4.15

1 similar comment
@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Sep 11, 2023

Cherry-picked PR Update configmap class constructor and documentation into v4.15

@redhat-qe-bot redhat-qe-bot mentioned this pull request Sep 11, 2023
Closed
@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Sep 11, 2023

Cherry-picked PR Update configmap class constructor and documentation into v4.14

redhat-qe-bot pushed a commit that referenced this pull request Sep 11, 2023
@oharan2 @rnetser
Update configmap class constructor and documentation (#1422)
6bd3292 
* Update configmap class constructor and documentation

* Update Data parameter as optional

---------

Co-authored-by: Ori Haran <oharan@distrobox-fedora.fedora>
Co-authored-by: Ruth Netser <rnetser@redhat.com>
@redhat-qe-bot redhat-qe-bot mentioned this pull request Sep 11, 2023
Closed
@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Sep 11, 2023

Cherry-picked PR Update configmap class constructor and documentation into v4.14

redhat-qe-bot pushed a commit that referenced this pull request Sep 11, 2023
@oharan2 @rnetser
Update configmap class constructor and documentation (#1422)
93eae20 
* Update configmap class constructor and documentation

* Update Data parameter as optional

---------

Co-authored-by: Ori Haran <oharan@distrobox-fedora.fedora>
Co-authored-by: Ruth Netser <rnetser@redhat.com>
redhat-qe-bot added a commit that referenced this pull request Sep 11, 2023
@redhat-qe-bot @oharan2 @rnetser
Update configmap class constructor and documentation (#1422) (#1451)
65f8a05 
* Update configmap class constructor and documentation

* Update Data parameter as optional

---------

Co-authored-by: oharan2 <oharan@redhat.com>
Co-authored-by: Ori Haran <oharan@distrobox-fedora.fedora>
Co-authored-by: Ruth Netser <rnetser@redhat.com>
redhat-qe-bot added a commit that referenced this pull request Sep 11, 2023
@redhat-qe-bot @oharan2 @rnetser
Update configmap class constructor and documentation (#1422) (#1450)
1d4f66e 
* Update configmap class constructor and documentation

* Update Data parameter as optional

---------

Co-authored-by: oharan2 <oharan@redhat.com>
Co-authored-by: Ori Haran <oharan@distrobox-fedora.fedora>
Co-authored-by: Ruth Netser <rnetser@redhat.com>
myakove pushed a commit that referenced this pull request Aug 11, 2025
@oharan2 @rnetser
Update configmap class constructor and documentation (#1422)
565c575 
* Update configmap class constructor and documentation

* Update Data parameter as optional

---------

Co-authored-by: Ori Haran <oharan@distrobox-fedora.fedora>
Co-authored-by: Ruth Netser <rnetser@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myakove myakove Awaiting requested review from myakove

@omrirh omrirh Awaiting requested review from omrirh

@rnetser rnetser Awaiting requested review from rnetser

Assignees

No one assigned

Labels

ApprovedBy-rnetser branch-main can-be-merged needs-rebase size/S verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oharan2 @redhat-qe-bot @rnetser