-
Notifications
You must be signed in to change notification settings - Fork 67
adding a restartCount class to resource #1534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Report bugs in Issues The following are automatically added:
Available user actions:
Supported /retest check runs
Supported labels
|
jpeimer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove gerrit links from the commit message
| INSTALL_READY = "InstallReady" | ||
| SUCCEEDED = "Succeeded" | ||
|
|
||
| class restartCount: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not every resource has the restartCount field, so it doesn't look like this suppose to be here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's more than one resource, it is OK to have it here (the other option is to have duplicates on multiple resources).
@Ahmad-Hafe which resources have restartCount ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think only pods/containers have restartCount. @Ahmad-Hafe is there any other resources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and DataVolumes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iiuc what you need, to get instance.status.restartCount should be a property and not a class
| INSTALL_READY = "InstallReady" | ||
| SUCCEEDED = "Succeeded" | ||
|
|
||
| class restartCount: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iiuc what you need, to get instance.status.restartCount should be a property and not a class
Short description:
I'm adding a new class to ocp_resources/resource.py
More details:
I need to track resource.instance.status.restartCount which is not applied to the wrapper
What this PR does / why we need it:
to get easy access to instance.status.restartCount
Which issue(s) this PR fixes:
None
Special notes for reviewer:
None
Bug:
None