Skip to content

adding a restartCount class to resource #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

adding a restartCount class to resource #1534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ocp_resources/resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,9 @@ class Phase:
INSTALL_READY = "InstallReady"
SUCCEEDED = "Succeeded"

class restartCount:
Copy link
Contributor

@jpeimer jpeimer Dec 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not every resource has the restartCount field, so it doesn't look like this suppose to be here

Copy link
Collaborator

@myakove myakove Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's more than one resource, it is OK to have it here (the other option is to have duplicates on multiple resources).

@Ahmad-Hafe which resources have restartCount ?

Copy link
Contributor

@dbasunag dbasunag Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only pods/containers have restartCount. @Ahmad-Hafe is there any other resources?

Copy link
Contributor

@jpeimer jpeimer Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and DataVolumes

Copy link
Collaborator

@rnetser rnetser Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iiuc what you need, to get instance.status.restartCount should be a property and not a class

restartCount = "restartCount"

class Reason:
ALL_REQUIREMENTS_MET = "AllRequirementsMet"
INSTALL_SUCCEEDED = "InstallSucceeded"
Expand Down