Skip to content

auto-cherry-pick: [v4.11] Do not require live cluster only for create class instance #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myakove merged 1 commit into from
Aug 11, 2022
Merged

auto-cherry-pick: [v4.11] Do not require live cluster only for create class instance #760

myakove merged 1 commit into from
Aug 11, 2022

Conversation

@cnv-qe-bot
Copy link

@cnv-qe-bot cnv-qe-bot commented Aug 11, 2022

cherry-pick #731 into v4.11

requested-by myakove

@myakove
Do not require live cluster only for create class instance (#731)
fc57f33 
* Do not require live cluster only for create class instance

* set version and client when needed
@cnv-qe-bot cnv-qe-bot self-assigned this Aug 11, 2022
@cnv-qe-bot cnv-qe-bot requested review from myakove and rnetser August 11, 2022 10:43
@cnv-qe-bot
Copy link
Author

cnv-qe-bot commented Aug 11, 2022

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR.

Available user actions:

  • To mark PR as verified add !verified to a PR comment, to un-verify add !-verified to a PR comment.
    Verified label removed on each new commit push.
  • To cherry pick a merged PR add !cherry-pick <target branch to cherry-pick to> to a PR comment.

@cnv-qe-bot cnv-qe-bot mentioned this pull request Aug 11, 2022
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@myakove
Copy link
Collaborator

myakove commented Aug 11, 2022

!verified

@myakove myakove merged commit 47aa6c5 into v4.11 Aug 11, 2022
@myakove myakove deleted the auto-cherry-pick-no-need-cluster-for-class-object branch August 11, 2022 10:51
@myakove
Copy link
Collaborator

myakove commented Aug 11, 2022

!cherry-pick v4.10

@cnv-qe-bot
Copy link
Author

cnv-qe-bot commented Aug 11, 2022

Manual cherry-pick is needed
Cherry pick failed for 47aa6c5 to v4.10:
error: could not apply 47aa6c5... Do not require live cluster only for create class instance (#731) (#760)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

To cherry-pick run: git cherry-pick 47aa6c55aae7cc0a8a7af7bfd877a13eb68b2a1f

myakove added a commit to myakove/openshift-python-wrapper that referenced this pull request Aug 11, 2022
@cnv-qe-bot @myakove
Do not require live cluster only for create class instance (RedHatQE#731
a7d0fff 
) (RedHatQE#760)

* Do not require live cluster only for create class instance

* set version and client when needed

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
myakove added a commit that referenced this pull request Aug 11, 2022
@myakove @cnv-qe-bot
Do not require live cluster only for create class instance (#731) (#760…
764455d 
…) (#762)

* Do not require live cluster only for create class instance

* set version and client when needed

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

Co-authored-by: cnv-qe-bot <87064384+cnv-qe-bot@users.noreply.github.com>
This was referenced Aug 11, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myakove myakove Awaiting requested review from myakove

@rnetser rnetser Awaiting requested review from rnetser

Assignees

@cnv-qe-bot cnv-qe-bot

Labels

auto-cherry-pick size/S verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cnv-qe-bot @myakove