Skip to content

Do not require live cluster only for create class instance (#731) (#760) #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myakove merged 1 commit into from
Aug 11, 2022
Merged

Do not require live cluster only for create class instance (#731) (#760) #762

myakove merged 1 commit into from
Aug 11, 2022

Conversation

@myakove
Copy link
Collaborator

@myakove myakove commented Aug 11, 2022

  • Do not require live cluster only for create class instance

  • set version and client when needed

Co-authored-by: Meni Yakove 441263+myakove@users.noreply.github.com

@cnv-qe-bot @myakove
Do not require live cluster only for create class instance (RedHatQE#731
a7d0fff 
) (RedHatQE#760)

* Do not require live cluster only for create class instance

* set version and client when needed

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
@cnv-qe-bot cnv-qe-bot requested a review from rnetser August 11, 2022 11:01
@cnv-qe-bot cnv-qe-bot mentioned this pull request Aug 11, 2022
Closed
@cnv-qe-bot
Copy link

cnv-qe-bot commented Aug 11, 2022

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR.

Available user actions:

  • To mark PR as verified add !verified to a PR comment, to un-verify add !-verified to a PR comment.
    Verified label removed on each new commit push.
  • To cherry pick a merged PR add !cherry-pick <target branch to cherry-pick to> to a PR comment.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@myakove
Copy link
Collaborator Author

myakove commented Aug 11, 2022

!verified

@myakove myakove merged commit 764455d into RedHatQE:v4.10 Aug 11, 2022
@myakove myakove deleted the no-need-cluster-for-class-object-v4.10 branch August 11, 2022 11:07
@myakove
Copy link
Collaborator Author

myakove commented Aug 11, 2022

!cherry-pick v4.9

@cnv-qe-bot
Copy link

cnv-qe-bot commented Aug 11, 2022

Manual cherry-pick is needed
Cherry pick failed for 764455d to v4.9:
error: could not apply 764455d... Do not require live cluster only for create class instance (#731) (#760) (#762)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

To cherry-pick run: git cherry-pick 764455d9a566ed70806140bf76687e94c0e142fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rnetser rnetser rnetser approved these changes

Assignees

@myakove myakove

Labels

size/L verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@myakove @cnv-qe-bot @rnetser