override create() and deploy() for projectrequest #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following are automatically added:
Available user actions:
|
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
|
!verified |
rnetser
requested changes
Dec 5, 2022
| """ | ||
| super().client_wait_deleted(timeout=timeout) | ||
|
|
||
| def deploy(self, wait=False): |
Collaborator
There was a problem hiding this comment.
this breaks using skip_resource_kind_create_if_exists
Comment on lines
+65
to
+72
| if not self.res: | ||
| self.to_dict() | ||
|
|
||
| self.logger.info(f"Create {self.kind} {self.name}") | ||
| self.logger.info(f"Posting {self.res}") | ||
| self.logger.debug(f"\n{yaml.dump(self.res)}") | ||
|
|
||
| self.api.create(body=self.res, namespace=self.namespace, dry_run=self.dry_run) |
Collaborator
There was a problem hiding this comment.
duplicate code, please save and re-use
Collaborator
|
Fixed by #998 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description: Need to override deploy() call for project request, as currently if an unprivileged user is making a projectrequest post call, using the base class create(), this call would fail due to
self.instance.metadata.resourceVersionline. As unprivileged user can't make this call.More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug: