Skip to content

create(): Fix initial_resource_version call #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myakove merged 1 commit into from
Dec 3, 2022
Merged

create(): Fix initial_resource_version call #998

myakove merged 1 commit into from
Dec 3, 2022

Conversation

@myakove
Copy link
Collaborator

@myakove myakove commented Dec 3, 2022

initial_resource_version use get and this fail when it's done with user without permissions

@cnv-qe-bot cnv-qe-bot requested a review from rnetser December 3, 2022 10:29
@cnv-qe-bot cnv-qe-bot mentioned this pull request Dec 3, 2022
Closed
@cnv-qe-bot
Copy link

cnv-qe-bot commented Dec 3, 2022

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR.

Available user actions:

  • To mark PR as verified add !verified to a PR comment, to un-verify add !-verified to a PR comment.
    Verified label removed on each new commit push.
  • To cherry pick a merged PR add !cherry-pick <target branch to cherry-pick to> to a PR comment.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@myakove
Copy link
Collaborator Author

myakove commented Dec 3, 2022

Fix for #997

@myakove
Copy link
Collaborator Author

myakove commented Dec 3, 2022

!verified

@myakove myakove merged commit c824fee into RedHatQE:main Dec 3, 2022
@myakove myakove deleted the create-fix-get-initial_resource_version branch December 3, 2022 10:31
@myakove
Copy link
Collaborator Author

myakove commented Dec 3, 2022

!cherry-pick v4.12

cnv-qe-bot pushed a commit that referenced this pull request Dec 3, 2022
@myakove
create(): Fix initial_resource_version call if the client do not have…
a093d31 
… permissions (#998)
@cnv-qe-bot cnv-qe-bot mentioned this pull request Dec 3, 2022
Merged
@cnv-qe-bot
Copy link

cnv-qe-bot commented Dec 3, 2022

Cherry-picked PR create(): Fix initial_resource_version call into v4.12

myakove added a commit that referenced this pull request Dec 3, 2022
@cnv-qe-bot @myakove
create(): Fix initial_resource_version call if the client do not have…
141249f 
… permissions (#998) (#1000)

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
@myakove myakove mentioned this pull request Dec 5, 2022
Closed
myakove added a commit that referenced this pull request Aug 11, 2025
@myakove
create(): Fix initial_resource_version call if the client do not have…
8314535 
… permissions (#998)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rnetser rnetser Awaiting requested review from rnetser

Assignees

@myakove myakove

Labels

branch-main size/XS verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@myakove @cnv-qe-bot