test(agent): unit tests for parseActionPlan, truncateString, and prepareHistoryParts#905
Merged
harshithmullapudi merged 3 commits intoJun 17, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 62 unit tests across 3 new test files to cover some previously untested pure-logic helpers in
services/agent/:decision.test.tsparseActionPlan,normalizeActionPlan,createFallbackPlantruncate-result.test.tstruncateString,truncateToolResultprepare-history-parts.test.tsprepareHistoryPartsThese helpers are used in decision parsing, history preparation, and tool-result truncation. Since they're pure functions with no DB or network dependencies, the added tests remain fast and deterministic while helping improve confidence around existing behavior.
Coverage Highlights
parseActionPlan: covers direct JSON parsing, code-fenced JSON parsing, regex fallback behavior, validation boundaries, and malformed input handling.truncateString: covers truncation behavior, head/tail split ratio, inline marker formatting, byte-count display (B/KB/MB), default limits, and metadata passthrough.prepareHistoryParts: covers role-based passthrough, tool-call preservation,tool-agent-*output collapsing, and edge cases around missing or non-string outputs.Testing
npx vitest run apps/webapp/app/services/agent/__tests__ # 5 files, 89 tests (62 new + 27 existing), 0 failures