Dev os notifications - #82
Conversation
| <PackageReference Include="Microsoft.AspNetCore.SignalR.Client" Version="10.0.3" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="10.0.3" /> | ||
| <PackageReference Include="NetCoreAudio" Version="2.0.1" /> | ||
| <PackageReference Include="OsNotifications" Version="1.1.5" /> |
There was a problem hiding this comment.
I took a quick look at the package, and it's essentially just ~3 source files with a fairly small amount of code. Given that, I'd lean towards implementing it directly in our codebase instead of introducing another dependency.
Few reasons:
- keep the dependency tree smaller,
- make the implementation easier to understand and debug,
- let us tweak the behavior if we ever need to, without waiting on or forking the package.
Unless the package provides functionality we're likely to benefit from in future updates, I think an in-house implementation would be the simpler long-term option.
There was a problem hiding this comment.
The reason I chose this package instead of directly implementing it here is the macOS implementation.
I don't think there is a way to build the macOS specific code required for notifications without a mac.
The package already includes the precompiled version & reference to the macOS APIs
There was a problem hiding this comment.
Makes sense, might add it to long term todos to revisit eventually 😆
f868ac1 to
fba8fbe
Compare
2 participants
Summary
See Changelog