Deduplicate benchmark downloads and propagate failures - #1030
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1030 +/- ##
==========================================
- Coverage 97.43% 97.40% -0.03%
==========================================
Files 141 141
Lines 8686 8686
==========================================
- Hits 8463 8461 -2
- Misses 223 225 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dor-forer
approved these changes
Sep 6, 2026
ethanglaser
added a commit
to ethanglaser/VectorSimilarity
that referenced
this pull request
Sep 11, 2026
Brings in RedisAI#1028 (SQ8-FP32 L2), RedisAI#1033 (SVSIndex::getDataByLabel), RedisAI#1021 (FP16 dispatch), RedisAI#1030-RedisAI#1032 (CI). No textual conflicts; the semantic fallout is fixed in the follow-up commit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The September 2 nightly timed out while downloading benchmark indices. The all-benchmarks path starts 73 downloads for 38 unique URLs with verbose progress output.
Deduplicate URLs and suppress progress output while retaining unlimited parallelism so larger runners can use their available bandwidth. Set a 60-second network timeout, three attempts, and a five-second retry wait. Enable strict shell error handling so failed downloads fail the step instead of being masked by
exit 0.Validation: shell syntax and whitespace checks; mocked downloads verified default/all and HNSW/SVS selections, one request per unique URL, download options, failure propagation in both paths, and no downloads for benchmarks without data. Rechecked deduplication and failure propagation after restoring unlimited parallelism. Full benchmark execution remains for CI.
Failure: https://github.com/RedisAI/VectorSimilarity/actions/runs/33677359784/job/100405740515
Note
Low Risk
CI/benchmark setup script only; no production or library behavior changes.
Overview
Refactors benchmark index fetching in
bm_files.shbehind a shareddownload_indiceshelper used for both the all-benchmarks and single-suite paths.URLs are merged from the index list files, blank lines dropped, and
sort -uso each URL is fetched once while keeping parallelwget(-P 0). Downloads use quieter logging (--no-verbose), a 60s timeout, three tries with a 5s retry wait, andset -euo pipefailso a failed download fails the step instead of being hidden behind success exits elsewhere in the script.Reviewed by Cursor Bugbot for commit 46646fc. Bugbot is set up for automated code reviews on this repo. Configure here.