Skip to content

Conversation

@manueljgarciar
Copy link
Contributor

In Gears v0.9 (latest), Run and Register functions doesn't work. It works fine now but it is not backward compatible from previous Gears versions.

In Gears v0.9 (latest), Run and Register functions doesn't work. It works fine now but it is not backward compatible from previous Gears versions.
@gkorland gkorland requested a review from MeirShpilraien April 5, 2020 20:48
@MeirShpilraien
Copy link

@manueljgarciar actually on RedisGears master (and the next version I am going to release in the next few days) the api changed again (https://github.com/RedisGears/RedisGears/blob/d14afe21c4eed6c00c787a167236df4436b8c8bf/src/GearsBuilder.py#L156), as each reader gets different set of parameters, it makes no sense to set them all in the run/register function and now those get only kargs and arguments extracted depends on the reader (still need to raise an error if an unmatched argument is given).

RedisGeas is not GA yet so I am allowing myself doing those kinds of breaking changes (once it will get GA I will no longer have this privilege).

I do not mind merging this change but keep in mind that more changes are probably going to be needed for the next version.

@MeirShpilraien MeirShpilraien merged commit 7a8eb04 into RedisGears:master Apr 5, 2020
@manueljgarciar
Copy link
Contributor Author

Thank you for the explanation.

@MeirShpilraien MeirShpilraien mentioned this pull request May 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants