Skip to content

Fixed #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2020
Merged

Fixed #7

merged 3 commits into from
May 6, 2020

Conversation

@MeirShpilraien
Copy link

@MeirShpilraien MeirShpilraien commented May 4, 2020

  1. No any spacific support from RedisGears is required now. This client use rg.pyexecute
  2. Match signitures of 'run' and 'register' functions
  3. Added repartition step

Fixed
40aa7ab 
1. No any spacific support from RedisGears is required now. This client use rg.pyexecute
2. Match signitures of 'run' and 'register' functions
3. Added repartition step
@MeirShpilraien MeirShpilraien requested a review from rafie May 4, 2020 17:56
@MeirShpilraien
Copy link
Author

MeirShpilraien commented May 4, 2020 •
edited
Loading

  • Add local aggregate and local aggregate by

rafie
rafie reviewed May 4, 2020
View reviewed changes
@MeirShpilraien
Copy link
Author

MeirShpilraien commented May 4, 2020

@manueljgarciar I know you used this RedisGears client before. Those are some of the changes I talked to you about here #6. If you want to take a look, feedback is appreciated.

rafie
rafie reviewed May 4, 2020
View reviewed changes
Copy link
Collaborator

@rafie rafie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool. One small typo.

@lgtm-com
Copy link

lgtm-com bot commented May 5, 2020

This pull request introduces 2 alerts when merging 94e3993 into 2556c4c - view on LGTM.com

new alerts:

  • 1 for Unnecessary pass
  • 1 for Unused import

@MeirShpilraien MeirShpilraien merged commit 3c1043c into master May 6, 2020
@lgtm-com
Copy link

lgtm-com bot commented May 6, 2020

This pull request introduces 2 alerts when merging 2ea9eaf into 2556c4c - view on LGTM.com

new alerts:

  • 1 for Unnecessary pass
  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafie rafie rafie left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MeirShpilraien @rafie