Skip to content

added circle tests #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2020
Merged

added circle tests #9

merged 2 commits into from
May 11, 2020

Conversation

@MeirShpilraien
Copy link

@MeirShpilraien MeirShpilraien commented May 11, 2020

No description provided.

@MeirShpilraien MeirShpilraien requested a review from gkorland May 11, 2020 11:53
@MeirShpilraien
Copy link
Author

MeirShpilraien commented May 11, 2020

#8

@lgtm-com
Copy link

lgtm-com bot commented May 11, 2020

This pull request introduces 1 alert when merging da3b990 into 4134b59 - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

@lgtm-com
Copy link

lgtm-com bot commented May 11, 2020

This pull request introduces 1 alert when merging dd1c1f0 into 4134b59 - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

@MeirShpilraien MeirShpilraien requested a review from rafie May 11, 2020 14:46
rafie
rafie reviewed May 11, 2020
View reviewed changes
Copy link
Collaborator

@rafie rafie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you'd like to remove early_return_for_forked_pull_requests? We can try creating a forked PR and see if it breaks.

@MeirShpilraien
Copy link
Author

MeirShpilraien commented May 11, 2020 •
edited
Loading

@rafie shouldn't it just work?
I just saw that we do not have it on RGSYNC so I removed it. I can take it back...

@rafie
Copy link
Collaborator

rafie commented May 11, 2020

@MeirShpilraien We had something similar in TimeSeries this week. CircleCI will not export environment variables to forked PRs in order not to expose secrets. In our modules, only Graph is implementing the early return. Let's try to go without it, and if it breaks, we put it back. I try to keep the config.yml files short and concise, but they manage to grow wild nevertheless.

@MeirShpilraien MeirShpilraien merged commit 8a42a62 into master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafie rafie rafie approved these changes

@gkorland gkorland Awaiting requested review from gkorland

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MeirShpilraien @rafie