chore: use dequal instead of lodash.isequal#1626
Merged
Merged
Conversation
|
Contributor
|
Contributor
Coverage report
Show files with reduced coverage 🔻
Test suite run success750 tests passing in 105 suites. Report generated by 🧪jest coverage report action from 88b9539 |
RomanHotsiy
approved these changes
Jul 12, 2024
RomanHotsiy
left a comment
Member
There was a problem hiding this comment.
LGTM. Just add a reference to the source of the dequal function.
JLekawa
approved these changes
Jul 12, 2024
tatomyr
force-pushed
the
chore/replace-lodash-with-dequal
branch
from
July 12, 2024 13:17
2e07732 to
88b9539
Compare
tatomyr
marked this pull request as ready for review
July 12, 2024 13:39
jeremyfiel
pushed a commit
to jeremyfiel/redocly-cli
that referenced
this pull request
Jul 16, 2024
* chore: use dequal instead of lodash.isequal * add a reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
It's smaller and more performant.
Reference
Testing
Screenshots (optional)
Check yourself
Security