Skip to content

chore: use dequal instead of lodash.isequal#1626

Merged
RomanHotsiy merged 2 commits into
mainfrom
chore/replace-lodash-with-dequal
Jul 12, 2024
Merged

chore: use dequal instead of lodash.isequal#1626
RomanHotsiy merged 2 commits into
mainfrom
chore/replace-lodash-with-dequal

Conversation

@tatomyr

@tatomyr tatomyr commented Jul 12, 2024

Copy link
Copy Markdown
Collaborator

What/Why/How?

It's smaller and more performant.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@tatomyr tatomyr self-assigned this Jul 12, 2024
@changeset-bot

changeset-bot Bot commented Jul 12, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 88b9539

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Jul 12, 2024

Copy link
Copy Markdown
Contributor
Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 984.7 ± 17.3 954.0 1004.5 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 994.7 ± 20.4 963.0 1031.5 1.01 ± 0.03

@github-actions

github-actions Bot commented Jul 12, 2024

Copy link
Copy Markdown
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 77.18% 4576/5929
🟡 Branches 67.18% 2526/3760
🟡 Functions 70.72% 751/1062
🟡 Lines 77.43% 4309/5565
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡 core/src/utils.ts
75.82% (-1.46% 🔻)
65.56% 75% 76.98%
🟡 core/src/bundle.ts 74.84% 62.71% 94.12% 74.84%

Test suite run success

750 tests passing in 105 suites.

Report generated by 🧪jest coverage report action from 88b9539

@RomanHotsiy RomanHotsiy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just add a reference to the source of the dequal function.

@tatomyr
tatomyr force-pushed the chore/replace-lodash-with-dequal branch from 2e07732 to 88b9539 Compare July 12, 2024 13:17
@tatomyr
tatomyr marked this pull request as ready for review July 12, 2024 13:39
@tatomyr
tatomyr requested a review from a team as a code owner July 12, 2024 13:39
@RomanHotsiy
RomanHotsiy merged commit 4e2f993 into main Jul 12, 2024
@RomanHotsiy
RomanHotsiy deleted the chore/replace-lodash-with-dequal branch July 12, 2024 13:55
jeremyfiel pushed a commit to jeremyfiel/redocly-cli that referenced this pull request Jul 16, 2024
* chore: use dequal instead of lodash.isequal

* add a reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants