Skip to content

chore: improve local development with marketing-pages#339

Merged
Daryna-del merged 3 commits into
mainfrom
chore/improve-local-development-with-marketing-pages
Jul 17, 2026
Merged

chore: improve local development with marketing-pages#339
Daryna-del merged 3 commits into
mainfrom
chore/improve-local-development-with-marketing-pages

Conversation

@Daryna-del

@Daryna-del Daryna-del commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

What/Why/How?

Improved local development with marketing-pages via yalc

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@Daryna-del Daryna-del self-assigned this Jul 17, 2026
@Daryna-del
Daryna-del marked this pull request as ready for review July 17, 2026 11:41
@Daryna-del
Daryna-del requested a review from a team as a code owner July 17, 2026 11:41

@redocly redocly Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marketing-site AI Review: 🟢 Completed

Reunite Agent has reviewed your changes and found 1 potential issue(s).

Note

Low Risk

This PR introduces configuration and script updates to improve the local developer experience, posing no risk to production functionality or existing behavior.

Overview

Introduces support for local development and testing with the @redocly/marketing-pages package using yalc.

  • Adds link-marketing-pages and unlink-marketing-pages to package.json scripts for linking and unlinking local package builds.
  • Updates .gitignore and redocly.yaml to ignore .yalc/ directories and yalc.lock files.
  • Documents the new development scripts in the README.md.

Comment thread package.json
"recheck:fix": "npx @redocly/recheck run --stats --fix"
"recheck:fix": "npx @redocly/recheck run --stats --fix",
"link-marketing-pages": "npx -y yalc add --link @redocly/marketing-pages",
"unlink-marketing-pages": "npx -y yalc remove --all"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: Low

The script is named unlink-marketing-pages, but uses --all which removes all yalc-linked packages. Consider using npx -y yalc remove @redocly/marketing-pages to only remove this specific package, avoiding unintended removal of other linked packages.

@Daryna-del Daryna-del changed the title chore: improve local developmant with marketing-pages chore: improve local development with marketing-pages Jul 17, 2026
@Daryna-del
Daryna-del merged commit 9d15278 into main Jul 17, 2026
6 of 7 checks passed
@Daryna-del
Daryna-del deleted the chore/improve-local-development-with-marketing-pages branch July 17, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants