Skip to content

chore: update dependencies#470

Open
tristan-f-r wants to merge 10 commits into
mainfrom
bump-all-deps
Open

chore: update dependencies#470
tristan-f-r wants to merge 10 commits into
mainfrom
bump-all-deps

Conversation

@tristan-f-r
Copy link
Copy Markdown
Collaborator

@tristan-f-r tristan-f-r commented Apr 29, 2026

I wanted to try out pyparsing for #431, but ran into some outdated dependency issues. We also:

@tristan-f-r tristan-f-r added the dependencies Pull requests that update a dependency file label Apr 29, 2026
@tristan-f-r tristan-f-r marked this pull request as draft April 29, 2026 07:40
@tristan-f-r tristan-f-r marked this pull request as ready for review April 30, 2026 21:25
@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented Apr 30, 2026

Documentation build overview

📚 spras | 🛠️ Build #32627735 | 📁 Comparing b972818 against latest (87b314c)

  🔍 Preview build  

2 files changed
± fordevs/spras.config.html
± fordevs/spras.html

@tristan-f-r tristan-f-r marked this pull request as draft May 1, 2026 01:49
@tristan-f-r
Copy link
Copy Markdown
Collaborator Author

See DataBiosphere/dsub#328 for the associated issue blocking a dependency bump.

@ntalluri
Copy link
Copy Markdown
Collaborator

ntalluri commented May 4, 2026

What specifically is this being used for the heuristics? Do we need to use pyparsing; is there a simpler way to parse?

@tristan-f-r
Copy link
Copy Markdown
Collaborator Author

tristan-f-r commented May 4, 2026

Tony mentioned boolean-parse, but it is also an unmaintained library with what seems to be no users. I'm much more comfortable just inlining the parsing logic we need because of that.

At the moment, we use a handwritten parser, but I notably made a few mistakes in said handwritten parser, so I would like to avoid using that in the future (one can also avoid that by adding a bucket of tests to said handwritten parser, but that seems suboptimal compared to having a nice way to declare the parser in the first place). Using pyparsing would end up being an easier implementation.

@tristan-f-r tristan-f-r marked this pull request as ready for review May 4, 2026 22:38
@tristan-f-r
Copy link
Copy Markdown
Collaborator Author

Oh, I can just bump down dsub.

@tristan-f-r tristan-f-r added the easy PRs which take at most a minute to review with little thinking. label May 4, 2026
@tristan-f-r tristan-f-r removed the easy PRs which take at most a minute to review with little thinking. label May 4, 2026
i was Very wrong about that
get_original_bases does _not_ have the same signature as its internal reflection counterpart!
pandas requires precisely one of (argument-based list specification) or (axis specification)
Trying to resolve mac errors
@tristan-f-r
Copy link
Copy Markdown
Collaborator Author

the parsing logic we need

We could also use an object representation, which would solve the parsing issue with the cost of making it a pain for users to specify heuristics.

This was referenced May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants