refactor: preserve list-generating data#474
Draft
tristan-f-r wants to merge 70 commits into
Draft
Conversation
This perplexes me but from my tests we do not need --keep-going. I do not know my original intent here
Co-Authored-By: Neha Talluri <78840540+ntalluri@users.noreply.github.com>
i was Very wrong about that
get_original_bases does _not_ have the same signature as its internal reflection counterpart!
pandas requires precisely one of (argument-based list specification) or (axis specification)
Trying to resolve mac errors
why did i not do this before???
this is why I didn't do this earlier...
tristan-f-r
added
the
refactor
tristan-f-r
changed the title
tristan-f-r
changed the title
ntalluri
reviewed
May 11, 2026
Collaborator
There was a problem hiding this comment.
is there a way to allow for someone to just put a list and have that tuned? I was assuming that was what TunableSet was but wanted to double check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will also contain configuration generation, especially since it serves as the nicest way to test this refactor, but I'm currently writing a new way to detect neighbors that I like more.
To assist in configuration generation, instead of re-creating the parsing at the CLI level, we store the backing information used to generate any programmatically-generated list in a generic
Tunableinterface, such that all algorithm parameters in theAlgorithmUnioninherit fromTunable. For the sake of parameter tuning,Tunablealso exposesTunable#tune, whose contract is specified in-documentation.