Add allowEmptyFragment option to no-useless-fragment, closes #1265
#1335
+189
−184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Rel1cx
force-pushed
the
no-useless-fragment
branch
from
c8c8c22 to
2ddbbd9
Compare
Copilot finished reviewing on behalf of
Rel1cx
December 3, 2025 07:32
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an allowEmptyFragment option to the no-useless-fragment ESLint rule, addressing issue #1265. The option allows developers to suppress warnings for empty fragments (<></>) when they are intentionally used (e.g., as placeholders or for type compatibility).
Key Changes:
- Added
allowEmptyFragmentboolean option (default:false) to the rule schema - Refactored the rule implementation by moving helper functions inside the
createfunction to access the new option - Updated message ID from string literal to computed type using
CamelCasehelper for consistency - Updated documentation links from
maintostablebranch
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/plugins/eslint-plugin/README.md |
Updated contributing and license documentation links from main to stable branch |
packages/plugins/eslint-plugin-react-x/src/rules/no-useless-fragment.ts |
Added allowEmptyFragment option, refactored helper functions as closures, and updated message ID to use computed type |
packages/plugins/eslint-plugin-react-x/src/rules/no-useless-fragment.spec.ts |
Updated all test cases to use new noUselessFragment message ID and added tests for the new option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/plugins/eslint-plugin-react-x/src/rules/no-useless-fragment.spec.ts
Show resolved
Hide resolved
Rel1cx
force-pushed
the
no-useless-fragment
branch
from
2ddbbd9 to
da1f8a3
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information