Skip to content

Add allowEmptyFragment option to no-useless-fragment, closes #1265 #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2025
Merged

Add allowEmptyFragment option to no-useless-fragment, closes #1265 #1335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/plugins/eslint-plugin-react-x/src/rules/no-useless-fragment.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ const cat = <>meow</>

This rule has a single options object with the following property:

- `allowEmptyFragment` (default: `false`): Allow fragments that contain no children.
- `allowExpressions` (default: `true`): Allow fragments that contain a single expression child.

## Note
Expand Down
79 changes: 38 additions & 41 deletions packages/plugins/eslint-plugin-react-x/src/rules/no-useless-fragment.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,30 @@ ruleTester.run(RULE_NAME, rule, {
errors: [
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "contains less than two children" },
},
],
output: null,
},
{
code: "<></>",
errors: [
{
type: T.JSXFragment,
messageId: "noUselessFragment",
data: { reason: "contains less than two children" },
},
],
options: [{ allowEmptyFragment: false }],
output: null,
},
{
code: "<>{}</>",
errors: [
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "contains less than two children" },
},
],
Expand All @@ -34,12 +46,12 @@ ruleTester.run(RULE_NAME, rule, {
errors: [
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "placed inside a host component" },
},
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "contains less than two children" },
},
],
Expand All @@ -50,7 +62,7 @@ ruleTester.run(RULE_NAME, rule, {
errors: [
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "contains less than two children" },
},
],
Expand All @@ -60,14 +72,9 @@ ruleTester.run(RULE_NAME, rule, {
{
code: "<p><>{meow}</></p>",
errors: [
// {
// type: T.JSXFragment,
// messageId: "uselessFragment",
// data: { reason: "contains less than two children" },
// },
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "placed inside a host component" },
},
],
Expand All @@ -78,7 +85,7 @@ ruleTester.run(RULE_NAME, rule, {
errors: [
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "contains less than two children" },
},
],
Expand All @@ -93,7 +100,7 @@ ruleTester.run(RULE_NAME, rule, {
errors: [
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "contains less than two children" },
},
],
Expand All @@ -106,7 +113,7 @@ ruleTester.run(RULE_NAME, rule, {
errors: [
{
type: T.JSXElement,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "contains less than two children" },
},
],
Expand All @@ -120,35 +127,21 @@ ruleTester.run(RULE_NAME, rule, {
errors: [
{
type: T.JSXElement,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "contains less than two children" },
},
],
output: `
<Foo />
`,
},
// {
// code: `
// <SomeReact.SomeFragment>
// {foo}
// </SomeReact.SomeFragment>
// `,
// errors: [
// {
// type: T.JSXElement,
// messageId: "uselessFragment",
// data: { reason: "contains less than two children" },
// },
// ],
// },
{
// Not safe to fix this case because `Eeee` might require child be ReactElement
code: "<Eeee><>foo</></Eeee>",
errors: [
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "contains less than two children" },
},
],
Expand All @@ -159,12 +152,12 @@ ruleTester.run(RULE_NAME, rule, {
errors: [
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "placed inside a host component" },
},
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "contains less than two children" },
},
],
Expand All @@ -175,7 +168,7 @@ ruleTester.run(RULE_NAME, rule, {
errors: [
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "placed inside a host component" },
},
],
Expand All @@ -191,7 +184,7 @@ ruleTester.run(RULE_NAME, rule, {
errors: [
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "placed inside a host component" },
},
],
Expand All @@ -207,7 +200,7 @@ ruleTester.run(RULE_NAME, rule, {
errors: [
{
type: T.JSXElement,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "placed inside a host component" },
},
],
Expand All @@ -226,13 +219,13 @@ ruleTester.run(RULE_NAME, rule, {
errors: [
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "placed inside a host component" },
line: 3,
},
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "placed inside a host component" },
line: 7,
},
Expand All @@ -249,7 +242,7 @@ ruleTester.run(RULE_NAME, rule, {
errors: [
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "placed inside a host component" },
},
],
Expand All @@ -266,13 +259,13 @@ ruleTester.run(RULE_NAME, rule, {
errors: [
{
type: T.JSXElement,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "placed inside a host component" },
line: 4,
},
{
type: T.JSXElement,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "contains less than two children" },
line: 4,
},
Expand All @@ -291,7 +284,7 @@ ruleTester.run(RULE_NAME, rule, {
errors: [
{
type: T.JSXFragment,
messageId: "uselessFragment",
messageId: "noUselessFragment",
data: { reason: "contains less than two children" },
},
],
Expand All @@ -305,6 +298,10 @@ ruleTester.run(RULE_NAME, rule, {
],
valid: [
...allValid,
{
code: "<></>",
options: [{ allowEmptyFragment: true }],
},
"<><Foo /><Bar /></>",
"<>foo<div /></>",
"<> <div /></>",
Expand Down
Loading