Skip to content

Remove Task tool from all crates#12

Merged
Sewer56 merged 1 commit intomainfrom
remove-task-tool
Jan 18, 2026
Merged

Remove Task tool from all crates#12
Sewer56 merged 1 commit intomainfrom
remove-task-tool

Conversation

@Sewer56
Copy link
Copy Markdown
Member

@Sewer56 Sewer56 commented Jan 18, 2026

Summary

Removes the Task tool from all three crates (core, rig, serdesai) as it was not wired up and users can implement their own task executors if needed.

This simplifies the codebase by removing:

  • Task executor trait and mock implementation from core
  • Task tool implementations from both rig and serdesai
  • Task context documentation
  • All related exports and references

Total reduction: 603 lines of code

Changes

Files Deleted

  • llm-coding-tools-core/src/operations/task.rs (198 lines)
  • llm-coding-tools-core/src/context/task.txt (53 lines)
  • llm-coding-tools-rig/src/task.rs (129 lines)
  • llm-coding-tools-serdesai/src/task.rs (193 lines)

Files Modified

  • Updated all lib.rs files to remove Task tool exports
  • Removed Task tool from operations/mod.rs
  • Removed TASK constant from tool_names.rs
  • Updated context/mod.rs to remove Task context

Testing

  • ✅ All 160 tests pass (83 core + 32 rig + 45 serdesai)
  • ✅ All doc tests pass
  • ✅ Both rig-basic and serdesai-basic examples compile and run successfully

Rationale

The Task tool required implementing a TaskExecutor trait to spawn sub-agents, but no concrete implementation existed beyond the mock. Users who need this functionality can implement their own executors tailored to their specific agent architecture.

The Task tool was not wired up and users can implement their own task executors if needed. This simplifies the codebase by removing:
- Task executor trait and mock implementation from core
- Task tool implementations from both rig and serdesai
- Task context documentation
- All related exports and references

All tests pass and examples run successfully.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 18, 2026

Warning

Rate limit exceeded

@Sewer56 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 15 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 81636ce and 0e98f64.

📒 Files selected for processing (10)
  • src/llm-coding-tools-core/src/context/mod.rs
  • src/llm-coding-tools-core/src/context/task.txt
  • src/llm-coding-tools-core/src/lib.rs
  • src/llm-coding-tools-core/src/operations/mod.rs
  • src/llm-coding-tools-core/src/operations/task.rs
  • src/llm-coding-tools-core/src/tool_names.rs
  • src/llm-coding-tools-rig/src/lib.rs
  • src/llm-coding-tools-rig/src/task.rs
  • src/llm-coding-tools-serdesai/src/lib.rs
  • src/llm-coding-tools-serdesai/src/task.rs
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-task-tool

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.26%. Comparing base (1202fdd) to head (0e98f64).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   59.34%   59.26%   -0.09%     
==========================================
  Files          49       46       -3     
  Lines        1338     1274      -64     
==========================================
- Hits          794      755      -39     
+ Misses        544      519      -25     
Flag Coverage Δ
unittests 59.26% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sewer56 Sewer56 merged commit c4927a9 into main Jan 18, 2026
5 checks passed
@Sewer56 Sewer56 deleted the remove-task-tool branch January 18, 2026 10:14
Sewer56 added a commit that referenced this pull request Mar 30, 2026
Remove Task tool from all crates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant