Fix: Align WebFetchOutput feature gates to tokio|blocking#46
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
WalkthroughThis pull request updates the conditional compilation feature flags for webfetch-related tools in two files. The change replaces the "async" feature requirement with the "tokio" feature while maintaining "blocking" as an alternative. The modifications affect the module inclusion and public re-exports of webfetch tools (fetch_url, format_json, html_to_markdown, and WebFetchOutput) in both the lib.rs root module and the tools/mod.rs submodule. Accompanying comments are updated to reflect the new feature gate terminology. Possibly related PRs
✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ba45ee7 to
4d15564
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 75.16% 75.16%
=======================================
Files 67 67
Lines 2029 2029
=======================================
Hits 1525 1525
Misses 504 504
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Fix: Align WebFetchOutput feature gates to tokio|blocking
Summary
Aligns the feature gate for
WebFetchOutputexport with itsFromimplementation.Problem
WebFetchOutputexport was gated byasync|blocking(inlib.rs:38andtools/mod.rs:27,30)From<WebFetchOutput> for ToolOutputwas gated bytokio|blocking(inoutput.rs:49)asyncfeature withouttokioChanges
async|blockingtotokio|blockingin:llm-coding-tools-core/src/lib.rs:38llm-coding-tools-core/src/tools/mod.rs:27,30