Skip to content

Fix: Align WebFetchOutput feature gates to tokio|blocking#46

Merged
Sewer56 merged 1 commit intomainfrom
fix/webfetch-feature-gates
Feb 28, 2026
Merged

Fix: Align WebFetchOutput feature gates to tokio|blocking#46
Sewer56 merged 1 commit intomainfrom
fix/webfetch-feature-gates

Conversation

@Sewer56
Copy link
Copy Markdown
Member

@Sewer56 Sewer56 commented Feb 28, 2026

Summary

Aligns the feature gate for WebFetchOutput export with its From implementation.

Problem

  • WebFetchOutput export was gated by async|blocking (in lib.rs:38 and tools/mod.rs:27,30)
  • From<WebFetchOutput> for ToolOutput was gated by tokio|blocking (in output.rs:49)
  • This caused an inconsistent API surface when building with async feature without tokio

Changes

  • Changed feature gates from async|blocking to tokio|blocking in:
    • llm-coding-tools-core/src/lib.rs:38
    • llm-coding-tools-core/src/tools/mod.rs:27,30

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 28, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 628235a and 4d15564.

📒 Files selected for processing (2)
  • src/llm-coding-tools-core/src/lib.rs
  • src/llm-coding-tools-core/src/tools/mod.rs

Walkthrough

This pull request updates the conditional compilation feature flags for webfetch-related tools in two files. The change replaces the "async" feature requirement with the "tokio" feature while maintaining "blocking" as an alternative. The modifications affect the module inclusion and public re-exports of webfetch tools (fetch_url, format_json, html_to_markdown, and WebFetchOutput) in both the lib.rs root module and the tools/mod.rs submodule. Accompanying comments are updated to reflect the new feature gate terminology.

Possibly related PRs

  • llm-coding-tools#31: Modifies the same feature gating for webfetch/tools re-exports by switching the cfg attribute from "async" to "tokio" with "blocking" as an alternative.
  • llm-coding-tools#29: Changes the same public re-export of webfetch tools in src/llm-coding-tools-core/src/lib.rs alongside renaming the operations module to tools.
✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/webfetch-feature-gates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sewer56 Sewer56 force-pushed the fix/webfetch-feature-gates branch from ba45ee7 to 4d15564 Compare February 28, 2026 13:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.16%. Comparing base (628235a) to head (4d15564).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   75.16%   75.16%           
=======================================
  Files          67       67           
  Lines        2029     2029           
=======================================
  Hits         1525     1525           
  Misses        504      504           
Flag Coverage Δ
unittests 75.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sewer56 Sewer56 merged commit 89606bc into main Feb 28, 2026
8 checks passed
@Sewer56 Sewer56 deleted the fix/webfetch-feature-gates branch February 28, 2026 13:37
Sewer56 added a commit that referenced this pull request Mar 30, 2026
Fix: Align WebFetchOutput feature gates to tokio|blocking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant