fix(ci): unblock main — TS blocklist parity + 3 lint errors#107
Merged
Conversation
…ed on main) internal/credentials/blocklist.go (canonical) added DONMAI_DAEMON_TOKEN and DONMAI_ORCHESTRATOR_URL in the recent debrand/security commits, but the TS duplicate at clients/credentials-client-ts/src/blocklist.ts was not synced. TestBlocklistParity_TSClient has been red on main since, blocking every PR. Mirror the two missing entries to restore parity. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… builtin shadow golangci-lint v2.11.4 is red on main (blocks the whole queue), in code from parallel subsystems unrelated to this branch's blocklist fix: - provider/gemini/handle.go:118 (gosec G118): cancel IS retained on Handle.cancel and invoked via h.cancel() (line 189) — false positive; annotate with a justified //nolint:gosec. - internal/interview/wiretypes.go (revive stutter): rename InterviewTokenChannel -> TokenChannel (zero callers; safe). - provider/gemini/gemini_test.go (revive redefines-builtin): rename local `cap` -> `maxTurns` (all 4 references). Verified: `golangci-lint run` reports 0 issues; gemini + interview tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MarkKropf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main'stestCI job is red on two independent fronts, blocking the entire donmai merge queue (every open PR, including the parallel gemini/credential/interview work). This PR greens all of it.1. TS blocklist parity (Test step)
TestBlocklistParity_TSClientfailed: Go canonicalinternal/credentials/blocklist.gogainedDONMAI_DAEMON_TOKEN+DONMAI_ORCHESTRATOR_URL(debrand/security commits) but the TS duplicateclients/credentials-client-ts/src/blocklist.tswas never synced (got 9, want 11). Mirrored the two entries — additive to a security blocklist, no behavior risk.2. Lint (golangci-lint v2.11.4, repo-wide)
Three pre-existing violations in parallel subsystems (not introduced here), surfaced by the lint version:
provider/gemini/handle.go:118— gosec G118 false positive:cancelis retained onHandle.canceland invoked viah.cancel()(line 189). Annotated with a justified//nolint:gosec.internal/interview/wiretypes.go— revive stutter:InterviewTokenChannel→TokenChannel(zero callers; safe rename).provider/gemini/gemini_test.go— revive redefines-builtin: test-localcap→maxTurns(all 4 refs).Verification
go test -run TestBlocklistParity ./clients/credentials-client-ts/...✅golangci-lint run→ 0 issues ✅go test ./provider/gemini/... ./internal/interview/... ./clients/credentials-client-ts/...✅🤖 Generated with Claude Code