Skip to content

enh: add skullduggery#159

Open
miltoncamacho wants to merge 1 commit intoReproNim:masterfrom
miltoncamacho:add_skullduggery
Open

enh: add skullduggery#159
miltoncamacho wants to merge 1 commit intoReproNim:masterfrom
miltoncamacho:add_skullduggery

Conversation

@miltoncamacho
Copy link
Copy Markdown

Add a BIDS compatible and robust population specific defacing tool.

See https://github.com/UNFmontreal/skullduggery by @bpinsard

@miltoncamacho miltoncamacho changed the title enh: add skulldiggery enh: add skullduggery Apr 20, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new Singularity recipe for bids-skullduggery version 0.0.2. The reviewer noted that using the :main tag for the base image compromises reproducibility and recommended pinning it to a specific version tag.

# See http://github.com/ReproNim/containers for more info
#
Bootstrap: docker
From: ghcr.io/unfmontreal/skullduggery:main
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using the :main tag for the base image in a versioned recipe (0.0.2) compromises reproducibility. If the main branch of the source repository is updated, subsequent builds of this Singularity image will contain different code, breaking the versioning contract. It is recommended to pin this to a specific version tag (e.g., :0.0.2) or a specific image digest.

From: ghcr.io/unfmontreal/skullduggery:0.0.2

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants