Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @asmacdo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
The pull request, titled "Resurrection 2025", focuses on modernizing the project's Python compatibility and performing general maintenance. Key changes include updating the minimum required Python version to 3.9, adjusting testing environments to support newer Python versions, and minor code cleanups related to command execution and test logic.
Highlights
- Python Version Update: The project's minimum Python requirement has been updated from 3.8 to 3.9 across documentation and build configurations.
- Testing Environment Refresh: The tox testing configuration has been updated to include Python versions 3.9 through 3.12, dropping support for older Python 2.7 and 3.4.
- Build Artifact Exclusion: pycache directories are now ignored by Git to keep the repository clean.
- Command Execution Refinement: The --verbose flag has been removed from the yum repolist command, streamlining its execution.
- Test Simplification: The test_version function has been simplified, removing redundant checks and platform-specific output handling.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the project to require Python 3.9+ and removes support for older versions. The changes are mostly consistent across the codebase, updating README.md, setup.py, and tox.ini. I've found a critical issue in reproman/distributions/redhat.py where a command was changed in a way that breaks subsequent parsing logic. I've also suggested a minor improvement to a test case for better precision. Please see the detailed comments.
| # '-y' included in case there are GPG keys to import | ||
| out, _ = self._session.execute_command(['yum', '--verbose', | ||
| 'repolist', '-y']) | ||
| out, _ = self._session.execute_command(['yum', 'repolist', '-y']) |
There was a problem hiding this comment.
Removing the --verbose flag from the yum repolist command will break the parsing logic that follows. The code iterates through the output lines and expects lines starting with Repo- (e.g., Repo-id, Repo-expire, Repo-baseurl), which are only present in the verbose output. The standard output of yum repolist is a table that does not follow this format. This change will cause _find_all_sources to fail to find any repository information.
| out, _ = self._session.execute_command(['yum', 'repolist', '-y']) | |
| out, _ = self._session.execute_command(['yum', '--verbose', 'repolist', '-y']) |
There was a problem hiding this comment.
it might break it, but --verbose is not an option on modern redhat systems. (IIUC it was removed in the transition to dnf)
| ok_startswith(out, 'reproman %s\n' % reproman.__version__) | ||
| in_("Copyright", out) | ||
| in_("Permission is hereby granted", out) | ||
| ok_startswith(stdout, f'reproman {reproman.__version__}') |
There was a problem hiding this comment.
The output of reproman --version from argparse includes a trailing newline. It would be more precise to include this in the assertion to ensure the output format is exactly as expected.
| ok_startswith(stdout, f'reproman {reproman.__version__}') | |
| ok_startswith(stdout, f'reproman {reproman.__version__}\n') |
2 participants
No description provided.