Enhance reprostim container with parallel, con-duct and co#212
Conversation
Summary of ChangesHello @vmdocua, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the utility of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds parallel and rsync to the container build process. My review highlights that the PR is incomplete as it's missing the installation of con-duct and py-spy which are mentioned in the description. I've also suggested adding tests for the new tools to ensure they are installed correctly. Please address these points to complete the intended enhancements.
| libsdl2-2.0-0 libzbar0 libusb-1.0-0-dev portaudio19-dev libasound2-dev pulseaudio pavucontrol pulseaudio-utils \ | ||
| vim wget strace time ncdu gnupg curl procps pigz less tree python3 python3-pip \ | ||
| ffmpeg mediainfo v4l-utils \ | ||
| ffmpeg mediainfo v4l-utils parallel rsync \ |
There was a problem hiding this comment.
This change adds parallel and rsync, but the pull request appears to be incomplete.
- The PR description states that
con-ductandpy-spyshould also be installed. These installations are missing from the current changes. They should likely be added aspipinstallations incontainers/repronim-reprostim/setup_container.sh. - To verify that the newly added tools work as expected, please consider adding tests for
parallelandrsyncintools/ci/test_reprostim_container.sh. This would be consistent with existing tests for tools likeffmpegandmediainfo.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #212 +/- ##
=========================================
- Coverage 3.09% 3.08% -0.01%
=========================================
Files 22 22
Lines 2782 2789 +7
Branches 405 406 +1
=========================================
Hits 86 86
- Misses 2696 2703 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🚀 PR was released in |
Preinstall into the container the following apps:
parallelrsynccon-ductviapippy-spy