Protect external jobs with lock file#213
Conversation
vmdocua
added
enhancement
Summary of ChangesHello @vmdocua, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the stability of external job execution by introducing a file-based locking mechanism. This ensures that critical long-running tasks, such as the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a file lock to the run_ext_nosignal function to prevent concurrent execution, which is a good step towards making the external job handling more robust. The implementation using filelock with a timeout is correct. However, the PR description states that both qr and nosignal jobs should be protected, but the lock is missing from the run_ext_qr function. Since run_ext_qr is also a long-running process that writes to files derived from a shared path, it should also be protected by a lock to prevent race conditions. I've also left a comment on a minor bug in a debug log statement.
| # run the command and capture output | ||
| # use lock file | ||
| path_lock: str = f"{vr.path}.nosignal.lock" | ||
| logger.debug("use lock file : {path_lock}") |
There was a problem hiding this comment.
The log message here is not an f-string, so it will print the literal string {path_lock} instead of the value of the path_lock variable. To fix this, you should add an f prefix to the string.
| logger.debug("use lock file : {path_lock}") | |
| logger.debug(f"use lock file : {path_lock}") |
|
🚀 PR was released in |
1 participant
Protect external jobs (like
qrandnosignal) with lock file, to provide access only to one thread in system execute long running tasks in concurrent mode. Other processes will fail if file is not accessible and in progress (allow 5 sec grace period to acquire lock).