Provide more tests for split-video command

[vmdocua]

Improve Python test code coverage for split-video command code to be 80%+ or higher.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a structured task list for the split-video command, serving as a detailed roadmap for its ongoing development. The primary focus of this document is to systematically define and track the necessary test cases to significantly improve the command's code coverage and overall robustness, ensuring a higher quality and more reliable tool.

Highlights

• New Task List Document: A new markdown document, .ai/task-split-video.md, has been added to provide a comprehensive task list for the split-video command, tracking its implementation progress against the specification.
• Detailed Test Plan: The task list includes an extensive section dedicated to 'Tests and Code Coverage', outlining specific test cases for timestamp/interval parsing, spec parsing, core splitting logic, sidecar JSON handling, multi-spec mode, integration tests, and CLI tests.
• Coverage Targets and Infrastructure: The document defines explicit code coverage targets for key modules (qr/split_video.py, cli/cmd_split_video.py) and specifies requirements for test infrastructure, such as creating a dedicated test file and providing synthetic video fixtures.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• .ai/task-split-video.md
  • Added a new markdown document to track the implementation and testing progress of the split-video command.
  • Detailed CLI options, core logic components, and expected outputs for the split-video command.
  • Outlined a comprehensive plan for improving test coverage, including specific test cases for various functionalities like parsing, splitting logic, and sidecar JSON.
  • Defined code coverage targets for relevant modules and specified requirements for test infrastructure.

Activity

• No specific activity (comments, reviews, progress) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a task list in a markdown file to track the implementation and testing of the split-video command. While having such a planning document is beneficial, the pull request's title and description ('Provide more tests for split-video command' and 'Improve test code coverage for split-video command') are misleading as no test code is actually added. It is recommended to update the title and description to accurately reflect that this PR adds a planning/task-tracking document.

_{Note: Security Review has been skipped due to the limited scope of the PR.}

[gemini-code-assist]

This item, along with the item on line 61 and the CLI help text, specifies the sidecar file extension as .jsonl. However, the current implementation in _resolve_sidecar_path in src/reprostim/qr/split_video.py generates a .json file. Furthermore, the _write_sidecar function writes a single pretty-printed JSON object, not a file in JSON Lines format. This inconsistency should be addressed. Please decide whether to align the implementation with the documentation (and this task list) by using .jsonl or to update the documentation to reflect the actual .json output.

[github-actions]

🚀 PR was released in 0.7.27 🚀