Make reprostim the default repronim-reprostim container entrypoint#232
Conversation
…tion and scripts, #217.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive task list and plan to configure the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a markdown file, .ai/task-container.md, which outlines a plan to make reprostim the default container entrypoint. However, the PR does not contain the actual code changes to implement this plan. The title, 'Make reprostim the default repronim-reprostim container entrypoint', is therefore misleading as it implies the work is completed. A pull request should ideally contain the code to be merged. This task list might be better suited as a comment on issue #217 or as part of a draft pull request description while the changes are being developed. I've also pointed out a potential contradiction in the planned tasks within the new file.
Note: Security Review has been skipped due to the limited scope of the PR.
| - [ ] **`setup_container.sh`**: Extend `PATH` to include `${PSYCHOPY_VENV_BIN}` (e.g. append to | ||
| `/etc/environment` or write a profile script under `/etc/profile.d/`) so that `reprostim` and | ||
| other venv binaries are accessible system-wide without individual wrappers. | ||
|
|
||
| - [ ] **`setup_container.sh`**: Add `/usr/local/bin/reprostim` wrapper script after the existing | ||
| `python3` wrapper (same pattern: write a one-line `#!/bin/sh` wrapper pointing to | ||
| `${PSYCHOPY_VENV_BIN}/reprostim`). |
There was a problem hiding this comment.
There seems to be a contradiction between the first two tasks for setup_container.sh. The first task aims to make reprostim accessible by adding its directory to the system PATH, explicitly stating it's to avoid individual wrappers. The second task, however, proposes creating exactly such a wrapper script for reprostim. These appear to be two alternative solutions. Could you clarify if both are needed, or if one is preferred? If the PATH is correctly extended, a separate wrapper script should be unnecessary.
|
🚀 PR was released in |
Refactor
repronim-reprostimcontainer to be more "native" in usage.Tasks:
python3toreprostimshim.typhon(will be completed after the PR is merged and released).Closes #217.