Skip to content

Add tslint for linting#1

Merged
wabieth merged 3 commits into
RequestNetwork:masterfrom
nikuda:linting
Jan 9, 2018
Merged

Add tslint for linting#1
wabieth merged 3 commits into
RequestNetwork:masterfrom
nikuda:linting

Conversation

@nikuda
Copy link
Copy Markdown
Contributor

@nikuda nikuda commented Nov 27, 2017

Linting the project will become very handy once more people start contributing.

Once there are no more lint error it would be worth adding npm run lint to a git pre-commit hook so that all the small errors get caught before they make it into the repository.

@vrolland
Copy link
Copy Markdown
Contributor

Hello Nikuda,

We planned to clean/comment/document this code in the coming weeks. The linting will be part of the process.
So your PR will probably help us. Thank you!

Best,

@QuentinFchx QuentinFchx mentioned this pull request Dec 19, 2017
@wabieth wabieth merged commit 7a4d44e into RequestNetwork:master Jan 9, 2018
@vrolland
Copy link
Copy Markdown
Contributor

vrolland commented Jan 9, 2018

Merged, thank you nikuda !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants