feat: replace symmetric encryption algorithm by aes-256-gcm#233
Merged
feat: replace symmetric encryption algorithm by aes-256-gcm#233
Conversation
vrolland
changed the title
vrolland
requested review from
addoxyz,
benjlevesque,
rittme and
yomarion
and removed request for
rittme
yomarion
approved these changes
Jun 22, 2020
Contributor
yomarion
left a comment
yomarion
left a comment
There was a problem hiding this comment.
Maybe we should specify somewhere that CBC was used before and we have to keep supporting it?
benjlevesque
approved these changes
Jun 22, 2020
rittme
approved these changes
Jun 22, 2020
Contributor
rittme
left a comment
rittme
left a comment
There was a problem hiding this comment.
This looks sleek. I love when good design pays off and something that could be a big undertaking is just a few changed files like this 🙂
|
|
||
| // Create the decipher object | ||
| const decipher = createDecipheriv(AES_256_CBC_ALGORITHM, key, iv); | ||
| // decipher.setAuthTag(authTag); |
Contributor
Author
I can't agree more! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
Following recommendations in the findings "RN-01-006 WP1" and "RN-01-007 WP1" of the encryption audit by Cure+53