Specs for proposal creation and additional homepage specs; spec helpers - #1076
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4dbd54023e
鈩癸笍 About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| * request-level check would notice. | ||
| */ | ||
| export function grantId(): string { | ||
| return requiredEnv('SMOKE_GRANT_ID'); |
There was a problem hiding this comment.
The new proposal spec calls grantId(), but the Run smoke tests step in .github/workflows/smoke.yml only exports SMOKE_BASE_URL, SMOKE_USER_EMAIL, and SMOKE_USER_PASSWORD. On a fresh GitHub runner there is no .env.development, so requiredEnv('SMOKE_GRANT_ID') throws before the proposal flow starts and makes every pull-request smoke run fail. Add the fixture ID to the workflow environment from an appropriate repository variable or secret.
Useful? React with 馃憤聽/ 馃憥.
| new URL(response.url()).pathname === '/api/researchhubpost/' && | ||
| response.request().method() === 'POST' | ||
| ); | ||
| await page.getByTestId('confirm-publish-submit').click(); |
There was a problem hiding this comment.
When the pull-request workflow runs against its configured shared environment, this click sends the real publication POST, and the test has no teardown; with the configured retry, one PR can leave multiple permanent proposals and grant applications behind. This continuously pollutes shared feeds and fixture state, and a manual run pointed at production would create user-visible test content there as well. Run this flow in an isolated disposable environment or provide reliable cleanup rather than publishing unbounded records.
Useful? React with 馃憤聽/ 馃憥.
1 participant
No description provided.