Skip to content

Encoding NSString from filePath HTML Content.#133

Merged
YuanZhu-apple merged 1 commit into
ResearchKit:masterfrom
LucianoTurrini:master
Sep 11, 2015
Merged

Encoding NSString from filePath HTML Content.#133
YuanZhu-apple merged 1 commit into
ResearchKit:masterfrom
LucianoTurrini:master

Conversation

@LucianoTurrini
Copy link
Copy Markdown

Encoding NSString from file Path HTML Content, if any errors in String from file Path HTML, the file does not load.

…g from file Path HTML, the file does not load.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we used fileURLWithPath: ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, for example: if the Bundle Identifier contain spaces or special characters surely will not Appear the HTML in the WebView, because the NSURL can not be built, it Shall be made a null NSURL. So is you need to use Encoding.

=) Use it:
NSURL *targetURL = [NSURL fileURLWithPath: filePath];

@YuanZhu-apple
Copy link
Copy Markdown
Member

Thanks!

YuanZhu-apple added a commit that referenced this pull request Sep 11, 2015
Encoding NSString from filePath HTML Content.
@YuanZhu-apple YuanZhu-apple merged commit 8338915 into ResearchKit:master Sep 11, 2015
@YuanZhu-apple
Copy link
Copy Markdown
Member

Sorry, I didn't realized fileURLWithPath: is not in, can you create a new PR?

@LucianoTurrini
Copy link
Copy Markdown
Author

=) Sure...it's done, Thank You very much

Erin-Mounts added a commit to Erin-Mounts/AppCore that referenced this pull request Oct 18, 2016
…gnized-unit

Fix bug with entering weight with a unit that is unrecognized or incudes spaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants