Skip to content

Encoding NSString from filePath HTML Content. #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YuanZhu-apple merged 1 commit into from
Sep 11, 2015
Merged

Encoding NSString from filePath HTML Content. #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion APCAppCore/APCAppCore/UI/Onboarding/APCStudyOverviewCollectionViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,8 @@ - (UICollectionViewCell *)collectionView:(UICollectionView *)collectionView cell

NSString *filePath = [[NSBundle mainBundle] pathForResource: studyDetails.detailText ofType:@"html" inDirectory:@"HTMLContent"];
NSAssert(filePath, @"Expecting file \"%@.html\" to be present in the \"HTMLContent\" directory, but didn't find it", studyDetails.detailText);
NSURL *targetURL = [NSURL URLWithString:filePath];
NSString *encodingFilePath = [filePath stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
NSURL *targetURL = [NSURL URLWithString:encodingFilePath];
Copy link
Copy Markdown
Member

@YuanZhu-apple YuanZhu-apple Sep 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we used fileURLWithPath: ?

Copy link
Copy Markdown
Author

@LucianoTurrini LucianoTurrini Sep 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, for example: if the Bundle Identifier contain spaces or special characters surely will not Appear the HTML in the WebView, because the NSURL can not be built, it Shall be made a null NSURL. So is you need to use Encoding.

=) Use it:
NSURL *targetURL = [NSURL fileURLWithPath: filePath];

NSURLRequest *request = [NSURLRequest requestWithURL:targetURL];
[webViewCell.webView loadRequest:request];

Expand Down