Skip to content

RE1-T115 Build fixes#340

Merged
ucswift merged 2 commits intomasterfrom
develop
Apr 23, 2026
Merged

RE1-T115 Build fixes#340
ucswift merged 2 commits intomasterfrom
develop

Conversation

@ucswift
Copy link
Copy Markdown
Member

@ucswift ucswift commented Apr 23, 2026

Summary by CodeRabbit

  • Chores
    • Upgraded application runtime from .NET 8.0 to .NET 9.0, providing access to latest performance improvements and security updates
    • Updated caching and API documentation dependencies to align with .NET 9 compatibility
    • Enhanced containerization efficiency

@request-info
Copy link
Copy Markdown

request-info Bot commented Apr 23, 2026

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

Warning

Rate limit exceeded

@ucswift has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 55 minutes and 6 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 55 minutes and 6 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d7fe086d-7ff3-471e-a397-4b85c9ceb4c4

📥 Commits

Reviewing files that changed from the base of the PR and between 25f80e2 and d68ba7f.

📒 Files selected for processing (1)
  • Web/Resgrid.Web.Tts/Dockerfile
📝 Walkthrough

Walkthrough

Upgrades the Resgrid.Web.Tts application from .NET 8.0 to .NET 9, including Docker container base images, runtime, and SDK versions, along with corresponding NuGet package updates for Redis caching and API documentation.

Changes

Cohort / File(s) Summary
TTS Project Upgrade to .NET 9
Web/Resgrid.Web.Tts/Dockerfile, Web/Resgrid.Web.Tts/Resgrid.Web.Tts.csproj
Retargets framework from net8.0 to net9.0; updates Docker runtime base from aspnet:8.0 to aspnet:9.0.3-noble-amd64 and SDK from sdk:8.0 to sdk:9.0.202-noble-amd64; adds BUILD_VERSION build argument; optimizes Dockerfile multi-stage build by adding base stage and leveraging --no-restore; updates NuGet dependencies: Microsoft.Extensions.Caching.StackExchangeRedis (8.0.0 → 9.0.2) and Swashbuckle.AspNetCore (6.6.2 → 8.0.0).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'RE1-T115 Build fixes' is vague and does not clearly communicate the primary changes to the codebase. Consider revising the title to be more descriptive, such as 'Upgrade .NET SDK to 9.0 and update Dockerfile' or 'Migrate web project to .NET 9.0 with updated dependencies'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
Web/Resgrid.Web.Tts/Dockerfile (1)

3-8: Base images pinned to -noble-amd64 — verify this matches your build/runtime targets.

Both the runtime (aspnet:9.0.3-noble-amd64) and SDK (sdk:9.0.202-noble-amd64) tags hardcode the linux/amd64 architecture. This is consistent across all Dockerfiles in the repository, but it will break any docker buildx multi-arch flow (e.g., ARM64 for AWS Graviton or Apple Silicon dev machines) and ignores the --platform flag. If multi-arch support is planned, consider dropping the -amd64 suffix across all Docker images to use manifest lists (9.0.3-noble, 9.0.202-noble) so the registry resolves the correct architecture automatically. This includes Workers/Resgrid.Workers.Console, Web/Resgrid.Web.Services, Web/Resgrid.Web.Mcp, Web/Resgrid.Web.Eventing, and Web/Resgrid.Web as well.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Web/Resgrid.Web.Tts/Dockerfile` around lines 3 - 8, The Dockerfiles pin
runtime and SDK images to the amd64 architecture (e.g., the FROM lines using
mcr.microsoft.com/dotnet/aspnet:9.0.3-noble-amd64 and
mcr.microsoft.com/dotnet/sdk:9.0.202-noble-amd64), which prevents multi-arch
builds; update those FROM references to the arch-agnostic manifest tags (remove
the -amd64 suffix, e.g., use 9.0.3-noble and 9.0.202-noble) or introduce build
ARGs like BASE_RUNTIME_IMAGE/BASE_SDK_IMAGE so the images resolve by manifest
and respect --platform, and apply the same change across the other Dockerfiles
(Workers/Resgrid.Workers.Console, Web/Resgrid.Web.Services, Web/Resgrid.Web.Mcp,
Web/Resgrid.Web.Eventing, Web/Resgrid.Web) for consistency.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Web/Resgrid.Web.Tts/Dockerfile`:
- Around line 1-18: The Dockerfile declares ARG BUILD_VERSION but never uses it;
either remove the unused ARG or wire it into the build and image metadata by
passing it to the dotnet publish (e.g., add /p:Version=$BUILD_VERSION or
/p:InformationalVersion=$BUILD_VERSION to the RUN dotnet publish
"Resgrid.Web.Tts.csproj" command) and/or add an OCI LABEL or ENV using
BUILD_VERSION in the base stage (e.g., LABEL build_version="$BUILD_VERSION" or
ENV BUILD_VERSION="$BUILD_VERSION") so the value is consumed by the image and
assemblies.

---

Nitpick comments:
In `@Web/Resgrid.Web.Tts/Dockerfile`:
- Around line 3-8: The Dockerfiles pin runtime and SDK images to the amd64
architecture (e.g., the FROM lines using
mcr.microsoft.com/dotnet/aspnet:9.0.3-noble-amd64 and
mcr.microsoft.com/dotnet/sdk:9.0.202-noble-amd64), which prevents multi-arch
builds; update those FROM references to the arch-agnostic manifest tags (remove
the -amd64 suffix, e.g., use 9.0.3-noble and 9.0.202-noble) or introduce build
ARGs like BASE_RUNTIME_IMAGE/BASE_SDK_IMAGE so the images resolve by manifest
and respect --platform, and apply the same change across the other Dockerfiles
(Workers/Resgrid.Workers.Console, Web/Resgrid.Web.Services, Web/Resgrid.Web.Mcp,
Web/Resgrid.Web.Eventing, Web/Resgrid.Web) for consistency.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 70c493fd-c43d-4fc3-bf02-7fdc090bf9d5

📥 Commits

Reviewing files that changed from the base of the PR and between ccd1d6f and 25f80e2.

📒 Files selected for processing (2)
  • Web/Resgrid.Web.Tts/Dockerfile
  • Web/Resgrid.Web.Tts/Resgrid.Web.Tts.csproj

Comment thread Web/Resgrid.Web.Tts/Dockerfile Outdated
@ucswift
Copy link
Copy Markdown
Member Author

ucswift commented Apr 23, 2026

Approve

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit d4f5f8c into master Apr 23, 2026
18 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant