Skip to content

RE1-T115 Fix#355

Merged
ucswift merged 1 commit intomasterfrom
develop
May 2, 2026
Merged

RE1-T115 Fix#355
ucswift merged 1 commit intomasterfrom
develop

Conversation

@ucswift
Copy link
Copy Markdown
Member

@ucswift ucswift commented May 2, 2026

Summary by CodeRabbit

  • Chores
    • Improved Docker build process to ensure build-wide properties are properly available during compilation steps.

@request-info
Copy link
Copy Markdown

request-info Bot commented May 2, 2026

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a025b406-7182-4138-bb28-19220ddd12b9

📥 Commits

Reviewing files that changed from the base of the PR and between 21f36d7 and dc0ed26.

📒 Files selected for processing (1)
  • Web/Resgrid.Web.Tts/Dockerfile

📝 Walkthrough

Walkthrough

A single line is added to the Docker build stage to copy Directory.Build.props into the build context before dotnet restore and dotnet publish operations, ensuring build-wide properties are available early in the build process.

Changes

Docker Build Configuration

Layer / File(s) Summary
Build Context Setup
Web/Resgrid.Web.Tts/Dockerfile
COPY ["Directory.Build.props", "./"] is added at line 12 in the build stage, before dotnet restore and dotnet publish, to make build properties available during dependency resolution and publishing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • RE1-T115 Build fixes #340: Also modifies Web/Resgrid.Web.Tts/Dockerfile to add files into the build context before restore/publish operations.
  • RE1-T115 S3 fix #354: Introduces Directory.Build.props; this PR ensures that file is available during the Docker build process.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'RE1-T115 Fix' is a vague issue reference that does not clearly describe the actual change made to the Dockerfile regarding Directory.Build.props copying. Consider using a more descriptive title like 'Copy Directory.Build.props early in Dockerfile build process' that explains the specific technical change being made.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@ucswift
Copy link
Copy Markdown
Member Author

ucswift commented May 2, 2026

Approve

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit 44cffc2 into master May 2, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant