Added RVD_HTTP_TIMEOUT configuration option to advanced.conf and conf…#2719
Merged
jaimecasero merged 2 commits intomasterfrom Dec 18, 2017
Merged
Added RVD_HTTP_TIMEOUT configuration option to advanced.conf and conf…#2719jaimecasero merged 2 commits intomasterfrom
jaimecasero merged 2 commits intomasterfrom
Conversation
…igured rvd.xml Refers #2718
jaimecasero
reviewed
Dec 18, 2017
| # MAIN | ||
|
|
||
| if [[ "$RVD_UNDEPLOY" = true || "$RVD_UNDEPLOY" = TRUE || "$RVD_UNDEPLOY" != True ]]; then | ||
| if [[ "$RVD_UNDEPLOY" = true || "$RVD_UNDEPLOY" = TRUE || "$RVD_UNDEPLOY" = True ]]; then |
Contributor
Author
There was a problem hiding this comment.
;-) ran some manual testing and fell right on it.
jaimecasero
reviewed
Dec 18, 2017
| RVD_URL='' # override if RVD is not under the same domain with restcomm. Use a base url like http://myrvd.restcomm.com . No path included. This affects restcomm.xml/<rcmlserver/> | ||
| RVD_VIDEO_SUPPORT='false' # Toggle RVD Video RCML generation and UI | ||
| RVD_MAX_MEDIA_FILE_SIZE=4194304 # Limit media file size when uploading. For video should probably be greater | ||
| RVD_HTTP_TIMEOUT='' # Timeout for http connections in rvd http client. It mainly affects connections to restcomm (create calls, fetch account etc.). It does not affect ES. |
Contributor
There was a problem hiding this comment.
do we need default value?. empty is using hardcoded? can you add comment with expected time units(secs,millis....)?
Contributor
Author
There was a problem hiding this comment.
@jaimecasero , if empty the setting (if exists) will be removed from rvd.xml and the default value in the rvd binary will be used.
Contributor
Author
There was a problem hiding this comment.
Let me add the time units (ms)
Contributor
|
im ok merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…igured rvd.xml
Refers #2718
Relates to #2711