Fix backticks in message definitions, throw better error on missing dependencies.#205
Merged
chris-smith merged 2 commits intoRethinkRobotics-opensource:develfrom Oct 21, 2024
Merged
Conversation
Until now, backticks ("`") in comments in message definitions will lead to an exception when the generated message is loaded, because the generated JS code is syntactically invalid.
Previously, if a custom message definition referred to another package that was missing, the error was not giving any clues as to where the problem occurred, i.e., which packages are involved. This change fixes that, making it much easy to debug broken dependencies.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #204 -- at least for this repo.
Message gen: escape backticks in comments
Until now, backticks ("`") in comments in message definitions will lead to an exception when the generated message is loaded, because the generated JS code is syntactically invalid.
Message generation: indicate name of missing dependencies
Previously, if a custom message definition referred to another package that was missing, the error was not giving any clues as to where the problem occurred, i.e., which packages are involved. This change fixes that, making it much easy to debug broken dependencies.