Skip to content

Fix bug with hasParam and getParamNames. #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chris-smith merged 2 commits into from
Oct 4, 2017
Merged

Fix bug with hasParam and getParamNames. #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e967ad8
Fix bug with hasParam and getParamNames.
JamesGiller Oct 3, 2017
ac56329
Remove redundant check that response code equals 1.
JamesGiller Oct 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions src/lib/ParamServerApiClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,15 +88,10 @@ class ParamServerApiClient {
];

return new Promise((resolve, reject) => {
this._xmlrpcClient.methodCall('hasParam', data, (err, resp) => {
if (err || resp[0] !== 1) {
reject(err, resp);
}
else {
// resp[2] is whether it actually has param and presumably all anyone cares about
resolve(resp[2]);
}
});
this._call('hasParam', data, (resp) => {
// resp[2] is whether it actually has param and presumably all anyone cares about
resolve(resp[2]);
}, reject);
});
}

Expand All @@ -106,15 +101,10 @@ class ParamServerApiClient {
];

return new Promise((resolve, reject) => {
this._xmlrpcClient.methodCall('getParamNames', data, (err, resp) => {
if (err || resp[0] !== 1) {
reject(err, resp);
}
else {
// resp[2] is parameter name list and presumably all anyone cares about
resolve(resp[2]);
}
});
this._call('getParamNames', data, (resp) => {
// resp[2] is parameter name list and presumably all anyone cares about
resolve(resp[2]);
}, reject);
});
}
}
Expand Down