More complete tests against gennodejs#8
Merged
IanTheEngineer merged 1 commit intoRethinkRobotics-opensource:kinetic-develfrom Apr 29, 2016
Merged
Conversation
| }); | ||
|
|
||
| describe('actions', () => { | ||
| // TODO: TEST actions |
Member
There was a problem hiding this comment.
We should track this in an issue, so as not to forget.
Member
|
+1 looks good to me. I'm going to merge as-is. Should we similarly test against ROS Services and a |
Collaborator
Author
|
|
| }); | ||
|
|
||
| it('services and constants', (done) => { | ||
| const BasicService = msgUtils.getHandlerForSrvType('test_msgs/BasicService'); |
Member
There was a problem hiding this comment.
I kinda glossed over that one. Good call. You've got a solid set of tests here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires test_msgs package available at https://github.com/RethinkRobotics-opensource/test_msgs.