Fixed how GoalHandle's status field is accessed in ActionServer.#91
Merged
chris-smith merged 2 commits intoRethinkRobotics-opensource:kinetic-develfrom Mar 22, 2018
Merged
Conversation
Merged
chris-smith
approved these changes
Mar 22, 2018
Collaborator
|
Thanks! |
jstnhuang
added a commit
to jstnhuang/rosnodejs
that referenced
this pull request
Mar 22, 2018
…hinkRobotics-opensource#91) * Fixed how GoalHandle's status field is accessed in ActionServer. * Provide full status message to publishResult.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status field of a GoalHandle is this._status, not this.status. I updated ActionServer to match.