Throw errors from requiring messages#94
Merged
IanTheEngineer merged 1 commit intokinetic-develfrom Mar 28, 2018
Merged
Conversation
IanTheEngineer
approved these changes
Mar 28, 2018
Member
IanTheEngineer
left a comment
IanTheEngineer
left a comment
There was a problem hiding this comment.
Looks good for merging!
| messagePackageMap[msgPackage] = ros_msg_utils.Find(msgPackage); | ||
| } | ||
| catch (err) { | ||
| throw new Error(`Unable to include message package ${msgPackage} - ${err}`); |
Member
There was a problem hiding this comment.
Wasn't this already re-throwing an error? Is the issue that it was swallowing the original error message?
Collaborator
Author
There was a problem hiding this comment.
The other function was swallowing the error but this was obscuring the actual error by changing the stack, making it harder for people to debug issues when they occur.
This was referenced Mar 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-If an error occurs while requiring a message package, throw it.
-Add tests for expected messages, throwing error when message doesn't exist
Relates to #93, #85